Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add Made for UDS badge verification task and workflow #1149

Merged
merged 52 commits into from
Oct 1, 2024
Merged

chore: add Made for UDS badge verification task and workflow #1149

merged 52 commits into from
Oct 1, 2024

Conversation

justinthelaw
Copy link
Contributor

@justinthelaw justinthelaw commented Sep 25, 2024 •
edited
Loading

Description

Implements the Made for UDS badge verification task for local execution and via a GitHub workflow. The workflow will output the findings into a reports/ archive for download.

BREAKING CHANGES

  • removes the UI package's extraneous Service sub-manifest, which caused a warning during bundle or package deployment

CHANGES

  • adds the Made for UDS badge verification UDS task
    • tasks are run like this: uds run verify-uds-badge-<PACKAGE_NAME>
  • adds a nightly workflow for UDS badge verification, outputs to archive
  • adds ignore for tasks.yaml from other workflow triggers

Related Issue

Relates to #1050
Relies on: defenseunicorns/uds-common#249

Checklist before merging

@justinthelaw justinthelaw self-assigned this Sep 25, 2024
@justinthelaw justinthelaw requested a review from a team as a code owner September 25, 2024 20:39
@justinthelaw justinthelaw linked an issue Sep 25, 2024 that may be closed by this pull request
feat(uds): add UDS badge task and workflow #1050
Closed
@netlify Netlify
Copy link

netlify bot commented Sep 25, 2024 •
edited
Loading

✅ Deploy Preview for leapfrogai-docs canceled.

Name Link
🔨 Latest commit 9bee643
🔍 Latest deploy log https://app.netlify.com/sites/leapfrogai-docs/deploys/66fc5993c08c5e0008646c7f

@justinthelaw justinthelaw changed the title chore: add Made for UDS badge verification workflow chore: add Made for UDS badge verification task Sep 25, 2024
@justinthelaw justinthelaw changed the title chore: add Made for UDS badge verification task chore: add Made for UDS badge verification task and workflow Sep 25, 2024
@justinthelaw justinthelaw marked this pull request as draft September 25, 2024 22:46
@justinthelaw justinthelaw added the blocked 🛑 Something needs to happen before this issues is worked label Sep 25, 2024
@justinthelaw
Copy link
Contributor Author

Blocked by defenseunicorns/uds-common#249

@justinthelaw justinthelaw marked this pull request as ready for review September 26, 2024 15:05
@justinthelaw justinthelaw removed the blocked 🛑 Something needs to happen before this issues is worked label Sep 26, 2024
@justinthelaw justinthelaw marked this pull request as ready for review September 30, 2024 15:25
@justinthelaw
Copy link
Contributor Author

justinthelaw commented Sep 30, 2024 •
edited
Loading

There seems to be an issue with the stdin and read streams within the runner that doesn't allow Python nor bash read the intermediate-report.txt for cleaning. At the moment, the only way to get the clean report is locally. The intermediate-report.txt. is still visible in the saved runner artifacts.

To run the test locally, look at the docs/DEVELOPMENT.md.

@justinthelaw
Copy link
Contributor Author

justinthelaw commented Sep 30, 2024 •
edited
Loading

See #1169 for the issue responsible for tracking and closing the badge verification test results.

This was referenced Oct 1, 2024
Merged
Open
gphorvath
gphorvath previously approved these changes Oct 1, 2024
View reviewed changes
@justinthelaw justinthelaw requested a review from gphorvath October 1, 2024 19:00
@justinthelaw justinthelaw merged commit 228c55c into main Oct 1, 2024
31 checks passed
@justinthelaw justinthelaw deleted the 1050-featuds-add-uds-badge-task-and-workflow branch October 1, 2024 21:07
@github-actions github-actions bot mentioned this pull request Oct 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CollectiveUnicorn CollectiveUnicorn CollectiveUnicorn approved these changes

@gphorvath gphorvath gphorvath approved these changes

Assignees

@justinthelaw justinthelaw

Labels
chore
Projects
None yet
Milestone
Next (M11) - Conformance | Stability ...
Development

Successfully merging this pull request may close these issues.

feat(uds): add UDS badge task and workflow
3 participants
@justinthelaw @gphorvath @CollectiveUnicorn